lvl0/buckets
1
0
Fork 0
Code Issues 11 Pull requests 1 Projects Releases Packages Wiki Activity Actions

5 - Add buffer multiplier parameter to CreateBucketAction

Browse source
This commit is contained in:
myrmidex 2026-03-20 00:31:04 +01:00
parent 50b7caf1f9
commit ad55a38c90
2 changed files with 79 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
app/Actions/CreateBucketAction.php
View file

@ -18,6 +18,7 @@ public function execute(
BucketTypeEnum $type = BucketTypeEnum::NEED,
?float $allocationValue = null,
?int $priority = null,
?float $bufferMultiplier = null,
): Bucket {
// Validate type + allocation type constraints
$this->validateTypeConstraints($type, $allocationType);
@ -30,12 +31,23 @@ public function execute(
// Validate allocation value based on type
$this->validateAllocationValue($allocationType, $allocationValue);
// Validate and normalize buffer multiplier
$bufferMultiplier = $bufferMultiplier ?? 0.0;
if ($bufferMultiplier < 0) {
throw new InvalidArgumentException('Buffer multiplier must be non-negative');
}
// Set allocation_value to null for unlimited buckets
if ($allocationType === BucketAllocationTypeEnum::UNLIMITED) {
$allocationValue = null;
}
return DB::transaction(function () use ($scenario, $name, $allocationType, $allocationValue, $priority, $type) {
// Buffer only applies to fixed_limit buckets
if ($allocationType !== BucketAllocationTypeEnum::FIXED_LIMIT) {
$bufferMultiplier = 0.0;
}
return DB::transaction(function () use ($scenario, $name, $allocationType, $allocationValue, $priority, $type, $bufferMultiplier) {
// Determine priority (append to end if not specified)
if ($priority === null) {
$maxPriority = $scenario->buckets()->max('priority') ?? 0;
@ -68,6 +80,7 @@ public function execute(
'sort_order' => $priority, // Start with sort_order matching priority
'allocation_type' => $allocationType,
'allocation_value' => $allocationValue,
'buffer_multiplier' => $bufferMultiplier,
]);
});
}

65
tests/Unit/Actions/CreateBucketActionTest.php
View file

@ -359,4 +359,69 @@ public function test_creates_buckets_in_database_transaction(): void
$this->assertEquals('Bucket 2', $buckets[0]->name); // New bucket at priority 1
$this->assertEquals('Bucket 1', $buckets[1]->name); // Original bucket shifted to priority 2
}
public function test_can_create_fixed_limit_bucket_with_buffer_multiplier(): void
{
$bucket = $this->action->execute(
$this->scenario,
'Buffered Bucket',
BucketAllocationTypeEnum::FIXED_LIMIT,
allocationValue: 50000,
bufferMultiplier: 1.5,
);
$this->assertEquals('1.50', $bucket->buffer_multiplier);
}
public function test_buffer_multiplier_defaults_to_zero(): void
{
$bucket = $this->action->execute(
$this->scenario,
'No Buffer Bucket',
BucketAllocationTypeEnum::FIXED_LIMIT,
allocationValue: 50000,
);
$this->assertEquals('0.00', $bucket->buffer_multiplier);
}
public function test_buffer_multiplier_forced_to_zero_for_percentage_bucket(): void
{
$bucket = $this->action->execute(
$this->scenario,
'Percentage Bucket',
BucketAllocationTypeEnum::PERCENTAGE,
allocationValue: 25.0,
bufferMultiplier: 1.0,
);
$this->assertEquals('0.00', $bucket->buffer_multiplier);
}
public function test_buffer_multiplier_forced_to_zero_for_unlimited_bucket(): void
{
$bucket = $this->action->execute(
$this->scenario,
'Unlimited Bucket',
BucketAllocationTypeEnum::UNLIMITED,
BucketTypeEnum::OVERFLOW,
bufferMultiplier: 1.0,
);
$this->assertEquals('0.00', $bucket->buffer_multiplier);
}
public function test_throws_exception_for_negative_buffer_multiplier(): void
{
$this->expectException(InvalidArgumentException::class);
$this->expectExceptionMessage('Buffer multiplier must be non-negative');
$this->action->execute(
$this->scenario,
'Bad Buffer',
BucketAllocationTypeEnum::FIXED_LIMIT,
allocationValue: 50000,
bufferMultiplier: -0.5,
);
}
}