Add inline editing for bucket name, allocation type, and allocation value #18

New issue

Closed

opened 2026-03-21 16:22:29 +01:00 by myrmidex · 0 comments

myrmidex commented

2026-03-21 16:22:29 +01:00

Owner

Problem

After creating a bucket, users cannot edit its name, allocation type, or allocation value — these are set-once at creation. The backend already supports partial updates for all three fields via PATCH /buckets/{uuid}, but the UI has no inline editing controls for them.

The existing inline editing pattern (InlineEditInput, InlineEditSelect) is already used for starting_amount, type, buffer_multiplier, and priority.

Scope

Add inline editing to bucket cards in Show.tsx for:

name — InlineEditInput (text, not numeric) or a new text variant. Currently displayed as a static <h3>.
allocation_type — InlineEditSelect with options: Fixed Limit, Percentage. Changing type should trigger a page reload to update dependent fields (buffer_multiplier visibility, allocation_value format). Disabled for overflow buckets.
allocation_value — InlineEditInput (numeric). Display format depends on allocation_type: $500.00 for fixed_limit, 25.00% for percentage. Hidden for unlimited/overflow buckets.

Notes

InlineEditInput currently only handles numeric values. For the name field, it may need a text mode or a new InlineEditText component.
When allocation_type changes, the backend auto-nulls allocation_value for unlimited and resets buffer_multiplier to 0 for non-fixed-limit types. The UI should reflect this after reload.
Backend validation already handles all three fields with sometimes rules — no backend changes needed.

Acceptance criteria

User can click bucket name to edit it inline
User can change allocation type via dropdown (except overflow buckets)
User can click allocation value to edit it inline
Changing allocation type refreshes the card to show/hide dependent fields
All changes persist via existing PATCH endpoint

## Problem After creating a bucket, users cannot edit its name, allocation type, or allocation value — these are set-once at creation. The backend already supports partial updates for all three fields via `PATCH /buckets/{uuid}`, but the UI has no inline editing controls for them. The existing inline editing pattern (`InlineEditInput`, `InlineEditSelect`) is already used for `starting_amount`, `type`, `buffer_multiplier`, and `priority`. ## Scope Add inline editing to bucket cards in `Show.tsx` for: - **name** — `InlineEditInput` (text, not numeric) or a new text variant. Currently displayed as a static `<h3>`. - **allocation_type** — `InlineEditSelect` with options: Fixed Limit, Percentage. Changing type should trigger a page reload to update dependent fields (buffer_multiplier visibility, allocation_value format). Disabled for overflow buckets. - **allocation_value** — `InlineEditInput` (numeric). Display format depends on allocation_type: `$500.00` for fixed_limit, `25.00%` for percentage. Hidden for unlimited/overflow buckets. ## Notes - `InlineEditInput` currently only handles numeric values. For the name field, it may need a text mode or a new `InlineEditText` component. - When `allocation_type` changes, the backend auto-nulls `allocation_value` for unlimited and resets `buffer_multiplier` to 0 for non-fixed-limit types. The UI should reflect this after reload. - Backend validation already handles all three fields with `sometimes` rules — no backend changes needed. ## Acceptance criteria - User can click bucket name to edit it inline - User can change allocation type via dropdown (except overflow buckets) - User can click allocation value to edit it inline - Changing allocation type refreshes the card to show/hide dependent fields - All changes persist via existing PATCH endpoint