Add Vite build step to CI pipeline

myrmidex commented

2026-03-30 01:09:59 +02:00

Owner

The CI workflow (ci.yml) only runs PHP checks (Pint, PHPStan, PHPUnit) but does not build frontend assets. This means broken JS/TS imports (like the dashboard route that broke the v0.2.0 image build) are not caught until the Docker image build step.

Problem:

npm run build is only run during docker build (Dockerfile line 51)
CI runs on push to release/* and PR to main — neither catches frontend build failures
Result: PHP tests pass green, PR merges, then the image build fails

Fix:
Add a Node.js setup + npm ci + npm run build step to ci.yml, running before PHP tests. This catches:

Broken imports (missing exports, typos)
TypeScript type errors
Vite/Rollup build failures

Scope:

Add Node.js 22 setup to CI
Cache node_modules via package-lock.json hash
Run npm run build as a CI step
Optionally run ESLint (npm run lint) as a separate step

This ensures both pushes to release/* and PRs to main validate the full build.

The CI workflow (`ci.yml`) only runs PHP checks (Pint, PHPStan, PHPUnit) but does **not** build frontend assets. This means broken JS/TS imports (like the `dashboard` route that broke the v0.2.0 image build) are not caught until the Docker image build step. **Problem:** - `npm run build` is only run during `docker build` (Dockerfile line 51) - CI runs on push to `release/*` and PR to `main` — neither catches frontend build failures - Result: PHP tests pass green, PR merges, then the image build fails **Fix:** Add a Node.js setup + `npm ci` + `npm run build` step to `ci.yml`, running **before** PHP tests. This catches: - Broken imports (missing exports, typos) - TypeScript type errors - Vite/Rollup build failures **Scope:** - Add Node.js 22 setup to CI - Cache `node_modules` via `package-lock.json` hash - Run `npm run build` as a CI step - Optionally run ESLint (`npm run lint`) as a separate step This ensures both pushes to `release/*` and PRs to `main` validate the full build.

myrmidex added this to the (deleted) milestone 2026-03-30 01:09:59 +02:00

myrmidex added the

bug

label 2026-03-30 01:09:59 +02:00

myrmidex commented

2026-06-14 20:15:30 +02:00

Author

Owner

Closing as folded into the new M1 (Foundation) milestone. In the Symfony + standalone React/Vite rebuild, the SPA build is no longer an add-on to gate — it's structural: the production image has two build stages (composer + vite build) and CI must build/lint/test the frontend as a first-class artifact. This is covered by M1's "re-derive the full CI/build pipeline" scope rather than a standalone ticket.

myrmidex closed this issue

2026-06-14 20:15:40 +02:00

Add Vite build step to CI pipeline #27