Add browser tests for editing and deleting users #57

New issue

Open

opened 2026-08-18 23:53:34 +02:00 by myrmidex · 0 comments

myrmidex commented

2026-08-18 23:53:34 +02:00

Owner

Gap

tests/Browser/Users/ contains only CreateUserTest.php. The UsersList Livewire component exposes full CRUD — create, store, edit, update, confirmDelete, delete, cancel — so edit and delete are untested in a browser.

Delete goes through a confirmation modal (confirmDelete → delete, with cancel), which is exactly the kind of multi-step Livewire interaction that feature tests do not fully exercise.

Compare tests/Browser/Dishes/, which has 6 tests including DeleteDishTest and DishDeletionSafetyTest — users deserve the same treatment.

Scope

In tests/Browser/Users/:

Edit: open the edit form, change a name, save, see the row update
Edit validation: invalid input shows errors, record unchanged
Delete: confirmation modal appears, confirming removes the row
Cancel: dismissing the modal leaves the user intact

Consider whether deleting a user with scheduled dishes needs a safety test, mirroring DishDeletionSafetyTest.

Blocked by #54

Write in Pest browser syntax after the Dusk → Pest migration.

Acceptance

Edit success and validation covered
Delete confirmation and cancel covered
Green in CI

## Gap `tests/Browser/Users/` contains only `CreateUserTest.php`. The `UsersList` Livewire component exposes full CRUD — `create`, `store`, `edit`, `update`, `confirmDelete`, `delete`, `cancel` — so edit and delete are untested in a browser. Delete goes through a confirmation modal (`confirmDelete` → `delete`, with `cancel`), which is exactly the kind of multi-step Livewire interaction that feature tests do not fully exercise. Compare `tests/Browser/Dishes/`, which has 6 tests including `DeleteDishTest` and `DishDeletionSafetyTest` — users deserve the same treatment. ## Scope In `tests/Browser/Users/`: - **Edit**: open the edit form, change a name, save, see the row update - **Edit validation**: invalid input shows errors, record unchanged - **Delete**: confirmation modal appears, confirming removes the row - **Cancel**: dismissing the modal leaves the user intact Consider whether deleting a user with scheduled dishes needs a safety test, mirroring `DishDeletionSafetyTest`. ## Blocked by #54 Write in Pest browser syntax after the Dusk → Pest migration. ## Acceptance - [ ] Edit success and validation covered - [ ] Delete confirmation and cancel covered - [ ] Green in CI