Activity page renders in light mode when the dashboard is in dark mode #156

Open
opened 2026-08-15 12:00:43 +02:00 by myrmidex · 0 comments
Owner

Steps to reproduce

  1. Set the theme to dark and open the dashboard
  2. Under Recent Activity, click View all
  3. /activity loads in light mode

The dashboard stays dark. Only the activity page reverts.

Expected

The theme carries across pages. Navigating away from the dashboard should not
change it.

To investigate

The theme is shared with views by App\Http\Middleware\HandleAppearance, which
reads an appearance cookie and defaults to system when it is absent. Worth
establishing:

  • Whether HandleAppearance runs for the /activity route. It is not
    registered in bootstrap/app.php's global middleware list, so which routes it
    applies to needs checking.
  • Whether the activity page reads the shared appearance value at all, or
    renders its own wrapper that omits it.
  • Whether the cookie is present on that request. If the theme is applied
    client-side after load, a page that does not run the same script would flash
    or stay light.
  • Whether other pages have the same problem, or whether /activity is alone.
    The dashboard, articles, feeds, channels, routes and settings pages should all
    be checked before assuming this is specific to one route.

The "View all" link itself is unlikely to be the cause, but it is worth ruling
out that it navigates differently from the sidebar link to the same page.

Acceptance criteria

  • /activity honours the selected theme when reached from the dashboard
  • It also honours it when reached from the sidebar and on a direct page load
  • Any other page found to have the same problem is fixed alongside it
  • The cause is understood rather than patched at the one route where it was
    noticed
## Steps to reproduce 1. Set the theme to dark and open the dashboard 2. Under **Recent Activity**, click **View all** 3. `/activity` loads in light mode The dashboard stays dark. Only the activity page reverts. ## Expected The theme carries across pages. Navigating away from the dashboard should not change it. ## To investigate The theme is shared with views by `App\Http\Middleware\HandleAppearance`, which reads an `appearance` cookie and defaults to `system` when it is absent. Worth establishing: - Whether `HandleAppearance` runs for the `/activity` route. It is not registered in `bootstrap/app.php`'s global middleware list, so which routes it applies to needs checking. - Whether the activity page reads the shared `appearance` value at all, or renders its own wrapper that omits it. - Whether the cookie is present on that request. If the theme is applied client-side after load, a page that does not run the same script would flash or stay light. - Whether other pages have the same problem, or whether `/activity` is alone. The dashboard, articles, feeds, channels, routes and settings pages should all be checked before assuming this is specific to one route. The "View all" link itself is unlikely to be the cause, but it is worth ruling out that it navigates differently from the sidebar link to the same page. ## Acceptance criteria - [ ] `/activity` honours the selected theme when reached from the dashboard - [ ] It also honours it when reached from the sidebar and on a direct page load - [ ] Any other page found to have the same problem is fixed alongside it - [ ] The cause is understood rather than patched at the one route where it was noticed
myrmidex added this to the v1.5.0 milestone 2026-08-15 12:00:44 +02:00
myrmidex added the
bug
label 2026-08-15 12:00:44 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lvl0/fedi-feed-router#156
No description provided.