Activity page renders in light mode when the dashboard is in dark mode #156
Labels
No labels
bug
devops
duplicate
enhancement
good first issue
layout
next major release
next minor release
question
research
testing
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: lvl0/fedi-feed-router#156
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Steps to reproduce
/activityloads in light modeThe dashboard stays dark. Only the activity page reverts.
Expected
The theme carries across pages. Navigating away from the dashboard should not
change it.
To investigate
The theme is shared with views by
App\Http\Middleware\HandleAppearance, whichreads an
appearancecookie and defaults tosystemwhen it is absent. Worthestablishing:
HandleAppearanceruns for the/activityroute. It is notregistered in
bootstrap/app.php's global middleware list, so which routes itapplies to needs checking.
appearancevalue at all, orrenders its own wrapper that omits it.
client-side after load, a page that does not run the same script would flash
or stay light.
/activityis alone.The dashboard, articles, feeds, channels, routes and settings pages should all
be checked before assuming this is specific to one route.
The "View all" link itself is unlikely to be the cause, but it is worth ruling
out that it navigates differently from the sidebar link to the same page.
Acceptance criteria
/activityhonours the selected theme when reached from the dashboardnoticed