From 16b579ecebab942ee1c2ca867b9c6f531fc0cdc9 Mon Sep 17 00:00:00 2001
From: myrmidex <myrmidex@myrmidex.net>
Date: Sat, 2 May 2026 09:57:05 +0200
Subject: [PATCH] 37 - Fix PR review findings: needsOnboarding gate, onSkip
 guard, sed patterns, compose cleanup

---
 docker/dev/container-start.sh                         | 2 +-
 docker/dev/docker-compose.yml                         | 3 ++-
 resources/js/components/Onboarding/OnboardingFlow.tsx | 2 +-
 resources/js/pages/dashboard.tsx                      | 2 +-
 4 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/docker/dev/container-start.sh b/docker/dev/container-start.sh
index ed49164..0371d10 100644
--- a/docker/dev/container-start.sh
+++ b/docker/dev/container-start.sh
@@ -7,7 +7,7 @@ if [ ! -f /var/www/html/.env ]; then
 fi
 
 # Fix database name to match compose file
-sed -i 's/DB_DATABASE=incr$/DB_DATABASE=incr_dev/' /var/www/html/.env
+sed -i 's|^DB_DATABASE=.*|DB_DATABASE=incr_dev|' /var/www/html/.env
 
 # Generate app key if not set or empty
 if ! grep -q "APP_KEY=base64:" /var/www/html/.env; then
diff --git a/docker/dev/docker-compose.yml b/docker/dev/docker-compose.yml
index 1a41b61..1962a31 100644
--- a/docker/dev/docker-compose.yml
+++ b/docker/dev/docker-compose.yml
@@ -59,4 +59,5 @@ networks:
 volumes:
   db_data:
     driver: local
-  app_node_modules:
\ No newline at end of file
+  app_node_modules:
+    driver: local
diff --git a/resources/js/components/Onboarding/OnboardingFlow.tsx b/resources/js/components/Onboarding/OnboardingFlow.tsx
index f7baba2..3053acf 100644
--- a/resources/js/components/Onboarding/OnboardingFlow.tsx
+++ b/resources/js/components/Onboarding/OnboardingFlow.tsx
@@ -183,7 +183,7 @@ export default function OnboardingFlow({ onComplete }: OnboardingFlowProps) {
             case 'milestones':
                 return <AddMilestoneForm onSuccess={handleStepComplete} />;
             case 'price':
-                return <PriceTrackingStep onEnable={handleStepComplete} onSkip={onComplete} />;
+                return <PriceTrackingStep onEnable={handleStepComplete} onSkip={onComplete ?? (() => {})} />;
             default:
                 return null;
         }
diff --git a/resources/js/pages/dashboard.tsx b/resources/js/pages/dashboard.tsx
index 71acacf..d52f1ec 100644
--- a/resources/js/pages/dashboard.tsx
+++ b/resources/js/pages/dashboard.tsx
@@ -106,7 +106,7 @@ export default function Dashboard() {
             const hasMilestones = milestonesData.length > 0;
 
             // User needs onboarding if any required step is missing
-            const needsOnboarding = !hasAsset || !hasPurchases || !hasMilestones;
+            const needsOnboarding = !hasPurchases || !hasMilestones;
             setNeedsOnboarding(needsOnboarding);
         } catch (error) {
             console.error('Failed to check onboarding status:', error);