41 - Unify InlineForm callbacks to onSuccess(type)

resources/js/components/Display/InlineForm.tsx

@@ -3,14 +3,14 @@ import AddMilestoneForm from '@/components/Milestones/AddMilestoneForm';
 import UpdatePriceForm from '@/components/Pricing/UpdatePriceForm';
 import { cn } from '@/lib/utils';
 
+type FormType = 'purchase' | 'milestone' | 'price';
+
 interface InlineFormProps {
-    type: 'purchase' | 'milestone' | 'price' | null;
+    type: FormType | null;
     unit?: string;
     priceTrackingEnabled?: boolean;
     onClose: () => void;
-    onPurchaseSuccess?: () => void;
+    onSuccess?: (type: FormType) => void;
-    onMilestoneSuccess?: () => void;
-    onPriceSuccess?: () => void;
     className?: string;
 }
 
@@ -19,13 +19,16 @@ export default function InlineForm({
     unit = 'units',
     priceTrackingEnabled = false,
     onClose,
-    onPurchaseSuccess,
+    onSuccess,
-    onMilestoneSuccess,
-    onPriceSuccess,
     className,
 }: InlineFormProps) {
     if (!type) return null;
 
+    const handleSuccess = () => {
+        if (onSuccess) onSuccess(type);
+        onClose();
+    };
+
     return (
         <div
             className={cn(
@@ -40,26 +43,17 @@ export default function InlineForm({
                         <AddEntryForm
                             unit={unit}
                             priceTrackingEnabled={priceTrackingEnabled}
-                            onSuccess={() => {
+                            onSuccess={handleSuccess}
-                                if (onPurchaseSuccess) onPurchaseSuccess();
-                                onClose();
-                            }}
                             onCancel={onClose}
                         />
                     ) : type === 'milestone' ? (
                         <AddMilestoneForm
-                            onSuccess={() => {
+                            onSuccess={handleSuccess}
-                                if (onMilestoneSuccess) onMilestoneSuccess();
-                                onClose();
-                            }}
                             onCancel={onClose}
                         />
                     ) : (
                         <UpdatePriceForm
-                            onSuccess={() => {
+                            onSuccess={handleSuccess}
-                                if (onPriceSuccess) onPriceSuccess();
-                                onClose();
-                            }}
                             onCancel={onClose}
                         />
                     )}

resources/js/pages/dashboard.tsx

@@ -292,9 +292,11 @@ export default function Dashboard() {
                             unit={tracker?.unit}
                             priceTrackingEnabled={priceTrackingEnabled}
                             onClose={() => setActiveForm(null)}
-                            onPurchaseSuccess={handlePurchaseSuccess}
+                            onSuccess={(type) => {
-                            onMilestoneSuccess={handleMilestoneSuccess}
+                                if (type === 'purchase') handlePurchaseSuccess();
-                            onPriceSuccess={handlePriceSuccess}
+                                else if (type === 'milestone') handleMilestoneSuccess();
+                                else if (type === 'price') handlePriceSuccess();
+                            }}
                         />
                     </div>
                 </div>