Unify InlineForm success callbacks to onSuccess(type) #41

New issue

Closed

opened 2026-05-02 13:35:19 +02:00 by myrmidex · 0 comments

myrmidex commented

2026-05-02 13:35:19 +02:00

Owner

InlineFormProps has three parallel optional callbacks (onPurchaseSuccess, onMilestoneSuccess, onPriceSuccess). As more form types are added this grows to n callbacks.

Fix: Replace with onSuccess: (type: 'purchase' | 'milestone' | 'price') => void. Parent dispatches based on type. Eliminates anonymous wrapper lambdas in InlineForm.tsx lines 43–62.

Effort: S — do when InlineForm is touched for another reason.

`InlineFormProps` has three parallel optional callbacks (`onPurchaseSuccess`, `onMilestoneSuccess`, `onPriceSuccess`). As more form types are added this grows to n callbacks. **Fix:** Replace with `onSuccess: (type: 'purchase' | 'milestone' | 'price') => void`. Parent dispatches based on type. Eliminates anonymous wrapper lambdas in `InlineForm.tsx` lines 43–62. **Effort:** S — do when `InlineForm` is touched for another reason.