Bring project documentation up to ffr's standard #61
Labels
No labels
bug
duplicate
enhancement
good first issue
help wanted
question
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: lvl0/incr#61
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
incr's project-level documentation is thin next to ffr's. Now that v0.4.0 has settled what the app actually is, the docs should match.
Licence — currently inconsistent in three places
LICENSEREADME.md(License section)composer.json:10Decision: relicense to AGPL v3, matching ffr. AGPL is GPL plus Section 13, which closes the network-use loophole — a fork hosted as a service must offer its source. Straightforward here: sole author, no external contributors.
LICENSEwith the AGPL v3 text (ffr's is the unmodified FSF version — copy it)composer.json→"license": "AGPL-3.0-or-later"CONTRIBUTING.md — missing
Mirror ffr's structure: Reporting issues · Development setup · Before opening a pull request · Commits · License.
Should reflect incr's own reality —
nix-shelland thedev-*helpers, the three gates (Pint, PHPStan level 7, PHPUnit), and the single-line<issue-id> - <Description>commit format.CHANGELOG.md — missing
Keep-a-Changelog format, as ffr uses. Start at
[0.4.0]— this milestone is a big enough story to be worth writing down properly: a VWCE share tracker became a counter, React/Inertia became Livewire, nine tables became one.Note ffr's
1.4.1entry already documents the same CI work done here (prebuilt image, wrong Composer cache path, DNS) — worth reading as a model for tone and level of detail.Screenshots — missing
ffr keeps them in
docs/screenshots/and embeds them in a## Screenshotssection after the intro, each with a sentence of context.incr needs far fewer — realistically two:
Both on the black/red terminal aesthetic, which is the most distinctive thing about the app and currently invisible to anyone reading the repo.
README gaps beyond the above
## Screenshotssection## Contributingsection pointing at CONTRIBUTING.md## Note on AI assistancesection; consider whether incr wants the sameAcceptance criteria
LICENSE,composer.jsonand README all state AGPL v3 — no contradictionsCONTRIBUTING.mdexists and describes incr's actual setup, not ffr'sCHANGELOG.mdexists with a[0.4.0]entrydocs/screenshots/, embedded in the READMENote
Requested for v0.4.0 rather than deferred, so the release ships with documentation that matches the app.
Scope correction: one screenshot, not two
The ticket asked for two — the counter and the set-value dialog. That was over-specified: incr is a single-view app, and the dialog opens on the same screen. Two near-identical images would pad the README rather than inform.
Reduced to one screenshot of the counter, with the caption mentioning
[SET VALUE].Acceptance criteria amended:
LICENSE,composer.jsonand README all state AGPL v3 — no contradictionsCONTRIBUTING.mdexists and describes incr's actual setup, not ffr'sCHANGELOG.mdexists with a[0.4.0]entryAt least two screenshotsOne screenshot indocs/screenshots/counter.png, embedded in the READMEDone —
2183dffand follow-upShipped in v0.4.0.
Licence
Was contradictory in three places:
LICENSEsaid GPL v3, the README said GPL v3,composer.json:10said MIT. All three now say AGPL v3.LICENSE— ffr's unmodified FSF AGPL text, verified identical and complete (Section 13 present)composer.json—"license": "AGPL-3.0-only", matching ffr's identifier exactlyCONTRIBUTING.md
Mirrors ffr's structure, but describes incr's own setup: its
dev-*commands includingdev-composer, its ports, MySQL rather than MariaDB, no Redis.Two deliberate differences from ffr's text:
CHANGELOG.md
Keep-a-Changelog format with a
[0.4.0]entry built from the closed tickets rather than memory.Screenshot
Scope reduced from two to one, per the comment above — incr is a single-view app and the dialog opens on the same screen, so two near-identical images would pad rather than inform.
docs/screenshots/counter.png, cropped from 3741×2022 to 3741×1150 because the counter sat in the top third with two-thirds empty black below. 321 kB → 139 kB, nothing clipped.README
Added Screenshot and Contributing sections; badge updated to AGPL.
Acceptance criteria
LICENSE,composer.jsonand README all state AGPL v3 — no contradictionsCONTRIBUTING.mdexists and describes incr's actual setup, not ffr'sCHANGELOG.mdexists with a[0.4.0]entrydocs/screenshots/counter.png, embedded in the README