lvl0/trove
1
0
Fork 0
Code Issues 11 Pull requests Projects Releases Packages Wiki Activity Actions

4 - Drop status promotion in UrlDiscoveredListener; defer to keywords listener
Some checks failed
CI / ci (push) Failing after 3h0m0s
Details

Browse source
This commit is contained in:
myrmidex 2026-04-26 03:52:12 +02:00
parent 3ad473f4a1
commit 6b610b699e
2 changed files with 4 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
app/Listeners/UrlDiscoveredListener.php
View file

@ -21,17 +21,13 @@ public function handle(UrlDiscovered $event): void
['status' => PageStatusEnum::Discovered, 'instance_id' => $event->instanceId], ['status' => PageStatusEnum::Discovered, 'instance_id' => $event->instanceId],
); );
if ($event->postUrl === null) { if ($event->postUrl === null || $event->postUrl === $event->url) {
return; return;
} }
$sourcePage = Page::firstOrCreate( $sourcePage = Page::firstOrCreate(
['url' => $event->postUrl], ['url' => $event->postUrl],
[ ['status' => PageStatusEnum::Discovered, 'instance_id' => $event->instanceId],
'status' => PageStatusEnum::Fetched,
'instance_id' => $event->instanceId,
'fetched_at' => $event->discoveredAt,
],
); );
PageLink::firstOrCreate([ PageLink::firstOrCreate([

5
tests/Feature/UrlDiscoveryTest.php
View file

@ -72,10 +72,9 @@ public function test_listener_creates_target_page_and_source_page_with_link(): v
// Source page // Source page
$sourcePage = Page::where('url', 'https://mastodon.social/@alice/109876543210')->first(); $sourcePage = Page::where('url', 'https://mastodon.social/@alice/109876543210')->first();
$this->assertNotNull($sourcePage); $this->assertNotNull($sourcePage);
$this->assertSame(PageStatusEnum::Fetched, $sourcePage->status); $this->assertSame(PageStatusEnum::Discovered, $sourcePage->status);
$this->assertSame($instance->id, $sourcePage->instance_id); $this->assertSame($instance->id, $sourcePage->instance_id);
$this->assertNotNull($sourcePage->fetched_at); $this->assertNull($sourcePage->fetched_at);
$this->assertTrue($discoveredAt->equalTo($sourcePage->fetched_at));
// Edge // Edge
$link = PageLink::where('source_page_id', $sourcePage->id) $link = PageLink::where('source_page_id', $sourcePage->id)