6 - Fix ntfy threshold config typing and layout title default

app/Services/PollAlertService.php

@@ -16,10 +16,10 @@ public function recordFailure(Instance $instance, string $message): void
         $instance->refresh();
 
         $ntfyUrl = config('services.ntfy.url');
-        $ntfyThreshold = (int) config('services.ntfy.threshold');
+        $ntfyThreshold = config('services.ntfy.threshold');
         $ntfyTopic = config('services.ntfy.topic');
 
-        if ($ntfyUrl === null || $ntfyThreshold === 0 || $ntfyTopic === null) {
+        if ($ntfyUrl === null || $ntfyThreshold === null || $ntfyThreshold === 0 || $ntfyTopic === null) {
             return;
         }
 

config/services.php

@@ -17,7 +17,7 @@
     'ntfy' => [
         'url' => env('NTFY_URL') ?: null,
         'topic' => env('NTFY_TOPIC') ?: null,
-        'threshold' => env('NTFY_THRESHOLD'),
+        'threshold' => env('NTFY_THRESHOLD') !== null ? (int) env('NTFY_THRESHOLD') : null,
     ],
 
     'postmark' => [

packages/Lvl0/FediDiscover/src/Console/Commands/PollInstancesCommand.php

@@ -52,7 +52,7 @@ public function handle(): int
 
         $errors->each(fn (array $errorArr) => PollFailed::dispatch(
             $errorArr['instance'],
-            $errorArr['error'] ?? '',
+            $errorArr['error'],
             now()->toImmutable(),
         ));
 

resources/views/layouts/app.blade.php

@@ -4,7 +4,7 @@
         <meta charset="utf-8">
         <meta name="viewport" content="width=device-width, initial-scale=1.0">
 
-        <title>Trove @yield('title')</title>
+        <title>Trove @yield('title', config('app.name'))</title>
 
         @vite(['resources/css/app.css', 'resources/js/app.js'])