22 - Drop redundant DB_HOST override from CI test step

.forgejo/workflows/ci.yml

@@ -73,7 +73,6 @@ jobs:
 
       - name: Tests with coverage
         env:
-          DB_HOST: db
           REDIS_HOST: redis
         run: php artisan test --coverage-clover coverage.xml --coverage-text
 

app/Providers/AppServiceProvider.php

@@ -2,13 +2,8 @@
 
 namespace App\Providers;
 
-use App\Listeners\PollFailedListener;
-use App\Listeners\UrlDiscoveredListener;
 use App\Services\LanguageDetectionService;
-use Illuminate\Support\Facades\Event;
 use Illuminate\Support\ServiceProvider;
-use Lvl0\FediDiscover\Events\PollFailed;
-use Lvl0\FediDiscover\Events\UrlDiscovered;
 
 class AppServiceProvider extends ServiceProvider
 {
@@ -19,7 +14,6 @@ public function register(): void
 
     public function boot(): void
     {
-        Event::listen(UrlDiscovered::class, UrlDiscoveredListener::class);
-        Event::listen(PollFailed::class, PollFailedListener::class);
+        //
     }
 }

phpunit.xml

@@ -28,13 +28,17 @@
     </source>
     <php>
         <server name="APP_ENV" value="testing"/>
+        <server name="APP_KEY" value="base64:AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="/>
         <server name="APP_MAINTENANCE_DRIVER" value="file"/>
         <server name="BCRYPT_ROUNDS" value="4"/>
         <server name="BROADCAST_CONNECTION" value="null"/>
         <server name="CACHE_STORE" value="array"/>
-        <server name="DB_CONNECTION" value="sqlite"/>
-        <server name="DB_DATABASE" value=":memory:"/>
-        <server name="DB_URL" value=""/>
+        <server name="DB_CONNECTION" value="pgsql"/>
+        <server name="DB_HOST" value="db"/>
+        <server name="DB_PORT" value="5432"/>
+        <server name="DB_DATABASE" value="trove"/>
+        <server name="DB_USERNAME" value="trove"/>
+        <server name="DB_PASSWORD" value="trove"/>
         <server name="MAIL_MAILER" value="array"/>
         <server name="QUEUE_CONNECTION" value="sync"/>
         <server name="SESSION_DRIVER" value="array"/>

tests/Feature/Actions/FetchPageActionTest.php

@@ -12,7 +12,7 @@
 use GuzzleHttp\Psr7\Request;
 use Illuminate\Support\Collection;
 use Illuminate\Support\Facades\Http;
-use Tests\TestCase;
+use Tests\Feature\TestCase;
 
 class FetchPageActionTest extends TestCase
 {

tests/Feature/Admin/InstancesAdminPageTest.php

@@ -6,15 +6,12 @@
 
 use App\Enums\PageStatusEnum;
 use App\Models\Page;
-use Illuminate\Foundation\Testing\RefreshDatabase;
 use Lvl0\FediDiscover\Config\InstanceType;
 use Lvl0\FediDiscover\Models\Instance;
-use Tests\TestCase;
+use Tests\Feature\TestCase;
 
 class InstancesAdminPageTest extends TestCase
 {
-    use RefreshDatabase;
-
     public function test_admin_instances_page_is_accessible(): void
     {
         $response = $this->get('/admin/instances');

tests/Feature/BotPageTest.php

@@ -4,8 +4,6 @@
 
 namespace Tests\Feature;
 
-use Tests\TestCase;
-
 class BotPageTest extends TestCase
 {
     public function test_bot_page_renders_at_public_route(): void

tests/Feature/Jobs/ProcessCrawlJobTest.php

@@ -12,18 +12,15 @@
 use App\Models\PageCrawl;
 use App\ValueObjects\FetchResult;
 use Carbon\Carbon;
-use Illuminate\Foundation\Testing\RefreshDatabase;
 use Illuminate\Support\Collection;
 use Illuminate\Support\Facades\Cache;
 use Illuminate\Support\Facades\Http;
 use Illuminate\Support\Facades\Queue;
 use Mockery;
-use Tests\TestCase;
+use Tests\Feature\TestCase;
 
 class ProcessCrawlJobTest extends TestCase
 {
-    use RefreshDatabase;
-
     public function test_creating_a_page_crawl_dispatches_process_crawl_job(): void
     {
         Queue::fake();

tests/Feature/Listeners/PollFailedListenerTest.php

@@ -8,17 +8,14 @@
 use App\Services\PollAlertService;
 use Carbon\CarbonImmutable;
 use Illuminate\Contracts\Queue\ShouldQueue;
-use Illuminate\Foundation\Testing\RefreshDatabase;
 use Lvl0\FediDiscover\Config\InstanceType;
 use Lvl0\FediDiscover\Events\PollFailed;
 use Lvl0\FediDiscover\Models\Instance;
 use Mockery;
-use Tests\TestCase;
+use Tests\Feature\TestCase;
 
 class PollFailedListenerTest extends TestCase
 {
-    use RefreshDatabase;
-
     public function test_handle_calls_record_failure_with_the_event_instance_and_message(): void
     {
         $instance = Instance::factory()

tests/Feature/PageQueuePopulationTest.php

@@ -7,13 +7,9 @@
 use App\Models\Page;
 use App\Models\PageCrawl;
 use App\Services\UrlService;
-use Illuminate\Foundation\Testing\RefreshDatabase;
-use Tests\TestCase;
 
 class PageQueuePopulationTest extends TestCase
 {
-    use RefreshDatabase;
-
     public function test_creating_a_page_inserts_a_page_crawl_row(): void
     {
         $url = 'https://example-blog.com/article';

tests/Feature/PollFailedIntegrationTest.php

@@ -4,18 +4,14 @@
 
 namespace Tests\Feature;
 
-use Illuminate\Foundation\Testing\RefreshDatabase;
 use Illuminate\Support\Facades\Http;
 use Lvl0\FediDiscover\Actions\PollFediverseAction;
 use Lvl0\FediDiscover\Config\InstanceType;
 use Lvl0\FediDiscover\Models\Instance;
 use RuntimeException;
-use Tests\TestCase;
 
 class PollFailedIntegrationTest extends TestCase
 {
-    use RefreshDatabase;
-
     public function test_poll_failure_increments_consecutive_poll_failures_via_full_chain(): void
     {
         Http::fake();

tests/Feature/Services/PollAlertServiceTest.php

@@ -5,16 +5,13 @@
 namespace Tests\Feature\Services;
 
 use App\Services\PollAlertService;
-use Illuminate\Foundation\Testing\RefreshDatabase;
 use Illuminate\Support\Facades\Http;
 use Lvl0\FediDiscover\Config\InstanceType;
 use Lvl0\FediDiscover\Models\Instance;
-use Tests\TestCase;
+use Tests\Feature\TestCase;
 
 class PollAlertServiceTest extends TestCase
 {
-    use RefreshDatabase;
-
     public function test_record_failure_increments_consecutive_poll_failures_on_the_instance(): void
     {
         $instance = Instance::factory()

tests/Feature/TestCase.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Feature;
+
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Tests\TestCase as BaseTestCase;
+
+abstract class TestCase extends BaseTestCase
+{
+    use RefreshDatabase;
+}

tests/Feature/UrlDiscoveryTest.php

@@ -9,17 +9,13 @@
 use App\Models\PageLink;
 use Carbon\CarbonImmutable;
 use Illuminate\Events\CallQueuedListener;
-use Illuminate\Foundation\Testing\RefreshDatabase;
 use Illuminate\Support\Facades\Queue;
 use Lvl0\FediDiscover\Config\InstanceType;
 use Lvl0\FediDiscover\Events\UrlDiscovered;
 use Lvl0\FediDiscover\Models\Instance;
-use Tests\TestCase;
 
 class UrlDiscoveryTest extends TestCase
 {
-    use RefreshDatabase;
-
     // ---------------------------------------------------------------------------
     // Helpers
     // ---------------------------------------------------------------------------

tests/Feature/UrlSubmissionTest.php

@@ -7,15 +7,11 @@
 use App\Enums\PageStatusEnum;
 use App\Livewire\UrlSubmissionForm;
 use App\Models\Page;
-use Illuminate\Foundation\Testing\RefreshDatabase;
 use Livewire\Livewire;
 use PHPUnit\Framework\Attributes\DataProvider;
-use Tests\TestCase;
 
 class UrlSubmissionTest extends TestCase
 {
-    use RefreshDatabase;
-
     // -------------------------------------------------------------------------
     // Test 1 — route renders the submission form
     // -------------------------------------------------------------------------