UrlDiscoveredListener: add tries and failed() handler #20

New issue

Closed

opened 2026-04-26 03:53:33 +02:00 by myrmidex · 0 comments

myrmidex commented

2026-04-26 03:53:33 +02:00

Owner

Context

App\Listeners\UrlDiscoveredListener implements ShouldQueue but has no $tries or failed() method. Default Laravel behavior on the production queue is effectively unlimited retries on transient failures.

Combined with the absence of unique-violation handling in firstOrCreate under concurrent listener execution (two workers racing on the same URL), a transient PG hiccup can trigger a retry storm with no audit trail.

Goal

Bound the retry count and add observability for permanent failures.

Acceptance criteria

public int $tries = 3; (or similar) on the listener.
public function failed(UrlDiscovered $event, Throwable $e): void that logs the event payload identity (instance_id, url, postUrl) plus the exception class and message at warning level.
A new test asserting that after exhausting retries, failed() is invoked with the right shape. Use Bus::fake() or queue-driver inspection.
Existing UrlDiscoveryTest tests still pass.

Out of scope

Dead-letter queue inspection tooling (separate ticket if needed).
Different retry strategies (exponential backoff, etc.).

## Context `App\Listeners\UrlDiscoveredListener` implements `ShouldQueue` but has no `$tries` or `failed()` method. Default Laravel behavior on the production queue is effectively unlimited retries on transient failures. Combined with the absence of unique-violation handling in `firstOrCreate` under concurrent listener execution (two workers racing on the same URL), a transient PG hiccup can trigger a retry storm with no audit trail. ## Goal Bound the retry count and add observability for permanent failures. ## Acceptance criteria - `public int $tries = 3;` (or similar) on the listener. - `public function failed(UrlDiscovered $event, Throwable $e): void` that logs the event payload identity (instance_id, url, postUrl) plus the exception class and message at warning level. - A new test asserting that after exhausting retries, `failed()` is invoked with the right shape. Use `Bus::fake()` or queue-driver inspection. - Existing UrlDiscoveryTest tests still pass. ## Out of scope - Dead-letter queue inspection tooling (separate ticket if needed). - Different retry strategies (exponential backoff, etc.).